-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add custom healpix plotting method #374
Conversation
Click here to view all benchmarks. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #374 +/- ##
==========================================
- Coverage 93.00% 92.87% -0.13%
==========================================
Files 49 49
Lines 2001 2134 +133
==========================================
+ Hits 1861 1982 +121
- Misses 140 152 +12 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, Sean!
@smcguire-cmu I played more! It gave me empty plot when I tried to do it for ALLWISE: import hipscat
catalog = hipscat.loaders.read_from_hipscat('https://data.lsdb.io/unstable/wise/allwise')
hipscat.inspection.plot_points(catalog) ![]() It also uses a lot of RAM, but it is probably expected? Zoomed version works fine import hipscat
from astropy.coordinates import Angle, SkyCoord
catalog = hipscat.loaders.read_from_hipscat('https://data.lsdb.io/unstable/wise/allwise')
hipscat.inspection.plot_points(catalog, center=SkyCoord(0, 0, unit='deg'), fov=(Angle(5, 'deg'), Angle(10, 'deg'))) ![]() |
@smcguire-cmu One more thing. It would be nice to make a "view window" to be a rectangle when |
Co-authored-by: Konstantin Malanchev <[email protected]>
2ef097f
to
0d30308
Compare
This was an interesting issue! Allwise has order 10 pixels in the point map, which are much smaller than a single pixel in the plot, so the part of the code that culls the backfacing cells detected them as invalid pixels and removed them all. I added some more functionality that merges any healpix pixels smaller than a single plot pixel. There's lots of ways that you can deal with aggregating multiple map pixels, but that's complicated. I figured a rendering engine with multiple objects in the same pixel would just pick one, so for now the behavior is to sample from the map and throw a warning. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is super-mega great, thank you!
Replaces healpy's plotting methods with a new healpix map plotting method based on mocpy's plotting functions.
Fixes #242